Skip to content

NH-4064 - Unmerge Antlr3.Runtime #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2017
Merged

Conversation

hazzik
Copy link
Member

@hazzik hazzik commented Aug 4, 2017

No description provided.

@hazzik hazzik added this to the 5.0 milestone Aug 4, 2017
@@ -67,7 +67,7 @@
<Prefer32Bit>false</Prefer32Bit>
</PropertyGroup>
<ItemGroup>
<Reference Include="Antlr3.Runtime, Version=3.5.0.2, Culture=neutral, PublicKeyToken=eb42632606e9261f, processorArchitecture=MSIL" Condition=" '$(Configuration)' == 'Debug' ">
<Reference Include="Antlr3.Runtime, Version=3.5.0.2, Culture=neutral, PublicKeyToken=eb42632606e9261f, processorArchitecture=MSIL">
<HintPath>..\packages\Antlr3.Runtime.3.5.1\lib\net40-client\Antlr3.Runtime.dll</HintPath>
<Private>True</Private>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This private thing was removed from ReLinq when doing NH-3750. It does not seem it changes anything to the reference property window though. (Copy local stays same.) And it is still there for Iesi too. So well, should it be kept or removed, I do not know.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be superseded by #605, so does not really matter. Oddly enough VS and MSBuild have different default behavior regards the copy local/private

@hazzik hazzik merged commit 9dec8c7 into nhibernate:master Aug 5, 2017
@hazzik hazzik deleted the NH-4064 branch August 5, 2017 05:32
@hazzik hazzik added the r: Fixed label Aug 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants