NH-3990 - Upgrade VB test project to VS2017 project structure #670
Conversation
| methodInfo.DeclaringType.FullName == "System.Data.Services.Providers.DataServiceProviderMethods") | ||
| return true; | ||
|
|
||
| if (methodInfo != null && methodInfo.Name == "CompareString" && |
There was a problem hiding this comment.
This is normally handled by VBStringComparisonExpression. The VB Core/New Roslyn case will be fixed in re-linq 2.2 (it's in alpha-3 now)
There was a problem hiding this comment.
Ok. Is this work-around fine for now, or should NHibernate depend on the alpha package?
There was a problem hiding this comment.
I think, test with 2.2-alpha3 and wait for the official release.
There was a problem hiding this comment.
This work-around will have to stay till re-linq 2.2.0-alpha-004.
There's no documented guarantee that IEnlistmentNotification.Prepare will be called from a different thread.
|
Don't want to wait as VS2017.3 is released. |
| <Import Include="System.Diagnostics" /> | ||
| <Import Include="System.Linq" /> | ||
| <Import Include="System.Xml.Linq" /> | ||
| <Compile Remove="Issues\NH3302\**" /> <!--"Like" not supported in new dotnet compiler, not implemented anyways in .net framework--> |
There was a problem hiding this comment.
Just noticed this. '"Like" not supported in new dotnet compiler' is not actually true.
There was a problem hiding this comment.
I think I meant that it's not implemented in the full .NET Framework version of NHibernate. At least it's ignored in the tests:
<TestFixture(), Ignore("Not fixed yet.")> _I don't actually know if it has been fixed, as I didn't try running it. Either way, the whole file doesn't compile with dotnet build.
There was a problem hiding this comment.
It's because Microsoft.VisualBaaic assembly is not referenced
Anyway it is already released, but not detected as an update from Visual Studio IDE. Launching the Visual Studio Installer detects it and allows installing it (at least from a 17.2). |
This is a continuation of #605.
dotnet test.CompareStringmethods being generated from LINQ queries.dotnet build, so that is addressed. Specifically,IEnlistmentNotification.Preparedoesn't seem to be guaranteed to be called from a different thread like it asserts.