NH-3990 - Fixes for upgrade to VS2017 project structure #672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredericDelaporte
previously approved these changes
Aug 10, 2017
|
Also, the tool needs the default generation path be changed as the tool is being compiled to a different folder now. |
|
And it needs a bit more indeed. It was embedding the mapping schema, but lost it during conversion to new format. Going to add a commit once I have get it running again. |
hazzik
previously approved these changes
Aug 11, 2017
fredericDelaporte
force-pushed
the
NH-3990-HbmXsdExe
branch
from
a85518e to
ab8fcb7
Compare
fredericDelaporte
approved these changes
Aug 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects a few issues with #605
ABC.hbm.xmlwas copied to thebinoutput folders, it was being re-included as an EmbeddedResource. This will cause problems when the VB project is migrated to VS 2017 and depends onNHibernate.Test.csproj. Solution is to exclude thebinfolders from being considered when finding files for embedding.