Skip to content

Conversation

@KoEonYack
Copy link
Contributor

@KoEonYack KoEonYack commented Sep 6, 2020

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

Copy link
Member

@seonim-ryu seonim-ryu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KoEonYack I reviewed. I'll approve this PR because the fixed content is simple. But next time, I hope you keep the commit message form and write the message in more detail. Thanks for your contributing. 🤝

@seonim-ryu seonim-ryu merged commit f309987 into nhn:master Sep 8, 2020
@KoEonYack
Copy link
Contributor Author

@seonim-ryu Thanks!! 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants