remove dead Error variants - #2
Merged
nicholascioli merged 1 commit intoMay 22, 2026
Merged
Conversation
NoIdInSample, InitialSchemaError, and ChannelClosed were emitted only from code paths that were removed when trimming the library to leaf primitives. None of the remaining schema-builder-library code emits them, and downstream consumers (schema-builder-orchestration) carry their own Error enum, so removing them from the library's public Error enum is safe.
Author
|
Superseded — commit pushed directly to separation-test so it shows up in mongodb#148. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes three Error variants from schema-builder-library that have no remaining emitters after the leaf-primitive trim:
Their original call sites lived in collection/mod.rs, context, and the channel-based orchestration that were removed earlier in this branch. The downstream schema-builder-orchestration crate (in 10gen/schema-manager-rs) carries its own Error enum with these variants, so removing them from the library Error enum is safe.
Verified locally:
Follow-up to surface review feedback on mongodb#148 before it lands.