Skip to content

Remove pybm report command, change pybm config list command #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2022

Conversation

nicholasjng
Copy link
Owner

This commit has two main contents:

  1. The pybm report command is now removed in favor of pybm compare, which now has the report functionality baked in via an additional command line switch --absolute.
  2. The pybm config list now prints the TOML file directly, simplifying from the previous logic.

Some more changes include:

  • All pybm component classes are now fetched through a single API, get_component_class.
  • The to_string() class method was added to the PybmConfig class.
  • Builder and git wrapper were made class attributes of the environment store, removing some duplicated code.
  • Some recyclable reporter tools were refactored into a new pybm.reporters.util module.

Bug fixes:

  • Strip trailing newline from git commits obtained by the resolve_commit function, which previously appeared in the commit SHA written to the config file after checkouts.

This commit has two main contents:
1) The `pybm report` command is now removed in favor of `pybm compare`, which now has the `report` functionality baked in via two additional command line switches.
2) The `pybm config list` now prints the TOML file directly, simplifying from the previous logic.

Some more changes include:
* All pybm component classes are now fetched through a single API, `get_component_class`.
* The `to_string()` class method was added to the PybmConfig class.
* Builder and git wrapper were made class attributes of the environment store, removing some duplicated code.
@nicholasjng nicholasjng merged commit 5bc883d into master Jan 23, 2022
@nicholasjng nicholasjng deleted the report-refactor branch February 13, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant