Multiple fixes enabling Windows support, environment benchmarking #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, make auto-install optional This commit fixes a bug where packages installed or uninstalled in `pybm env install/uninstall` commands would not be added to / removed from the environment TOML file due to a missing context manager. Secondly, the post-venv-creation step of installing runner requirements into the new virtual environment is not made optional, controlled through a config option `builder.autoinstall`.
This commit enables pybm benchmark runs on Windows systems by fixing the git version tuple parsing from the output of `git version`. Previously, parsing would fail due to a trailing dot in the string match obtained from the regex matching, which happened because git versions on Windows are of the form MAJ.MIN.PATCH.windows.X. With the previous regex, the dot after PATCH would be picked up, leading to an empty string in the string split, causing it to fail. The new regex picks up groups of dots AND THEN numbers, ensuring that a capture group never ends on a dot. Additionally, a method to find the local config in the main worktree with git was added, which previously broke benchmarking in repositories with the pybm config ignored from source control.
This commit simplifies the TimeitRunner class. A loop was removed by passing the repetitions argument to the Timer.repeat API of timeit, which then returns a list that can be distributed into multiple JSON results. At the end, benchmark results are assembled as a shallow copy of a local benchmark template constructed at the beginning of the run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.