remove v2

[HeChuanXUPT]

No description provided.

[codecov]

Codecov Report

Merging #179 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #179   +/-   ##
=======================================
  Coverage   82.33%   82.33%           
=======================================
  Files          14       14           
  Lines        1285     1285           
=======================================
  Hits         1058     1058           
  Misses        161      161           
  Partials       66       66

Impacted Files	Coverage Δ
goi18n/merge_command.go	74.43% <ø> (ø)	⬆️
i18n/localizer.go	80.43% <ø> (ø)	⬆️
goi18n/main.go	81.94% <ø> (ø)	⬆️
i18n/bundle.go	59.61% <ø> (ø)	⬆️
i18n/message_template.go	75% <ø> (ø)	⬆️
goi18n/marshal.go	80.55% <ø> (ø)	⬆️
goi18n/extract_command.go	69.04% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38f9eac...6387517. Read the comment docs.

[nicksnyder]

I can’t merge this because the v2 suffix is necessary to avoid breaking backward compatibility with v1. Can you explain the problem you have that motivated this PR?

[HeChuanXUPT]

I got some errors when go build my program.
use go-i18n in the vendor directory
The documentation link in the readme is also not found
https://godoc.org/github.com/nicksnyder/go-i18n/v2/i18n

[nicksnyder]

What are you using to vendor? What version of Go are you using?

[HeChuanXUPT]

go version 1.10

[nicksnyder]

Can you upgrade to 1.10.3+? I think that might solve your problem.

[nicksnyder]

More info here: https://github.com/golang/go/wiki/Modules#how-are-v2-modules-treated-in-a-build-if-modules-support-is-not-enabled-how-does-minimal-module-compatibility-work-in-197-1103-and-111

[nicksnyder]

And what are you using to generate your vendor folder?

[HeChuanXUPT]

I use go vendor to manage packages

mkdir -p vendor/github.com/nicksnyder/
cd vendor/github.com/nicksnyder/
git clone https://github.com/nicksnyder/go-i18n.git

[nicksnyder]

go-i18n v2 is configured to work with Go modules as documented here: https://github.com/golang/go/wiki/Modules

Note that Go modules works best with 1.10.3+, so the easiest fix is probably to upgrade your version of go to at least 1.11.

If helpful, you can checkout the v2.0.0 tag when the v2 code was in a v2 subfolder.
You could also fix your vendor folder to put the i18n package under a v2 directory. If you upgrade to go 1.11+ then go mod vendor should do this for you.

I am aware that some of the go doc links are broken, and am waiting for a resolution here: golang/gddo#567 (comment)

I am going to close this PR because ultimately this is something that you will need to fix on your end, but I hope the above suggestions are helpful and sorry for the inconvenience.

[HeChuanXUPT]

ok, thanks

[nicksnyder]

I restored the v2 subdirectory for greater compatibility so you should be able to update to 2.0.2