Skip to content

Fix/suppress reconnect popups without suppressing events #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mgmachado
Copy link

Issue this PR solves: coder#1791

On a connection loss, the client attempts to reconnect up to twice in the background before displaying the reconnection pop-up.

Copy link

@choyrim choyrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed no sensitive data included.

@mgmachado mgmachado force-pushed the fix/suppress_reconnect_popups_without_suppressing_events branch from 20c9d83 to fee0ba9 Compare November 18, 2020 20:25
@mgmachado mgmachado force-pushed the fix/suppress_reconnect_popups_without_suppressing_events branch from fee0ba9 to 4090146 Compare November 18, 2020 21:25
@choyrim choyrim self-requested a review November 18, 2020 21:32
@mgmachado mgmachado merged commit 12ab91b into nielsen Nov 18, 2020
mgmachado pushed a commit that referenced this pull request Dec 7, 2020
'How do I debug issues with code-server?` section of FAQ listed the logs for VS Code for #2. This commit includes the log location for code-server.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants