Switch piracy check to warning

[Top-Cat]

The current check is a joke.

The repo is open source and there are already multiple forks with the code removed. The second has an automatic script to merge in changes made here. I'm happy to add to that list if you want.

You already have open issues with users using legitimate tools and being blocked. Getting in the way will only push people to use forks of this repo and give you less control.

Furthermore you've gotten plenty of pushback from modders who don't want this either and you seem unwilling to listen.

One of two things is going to happen:

• This check is going to be changed
• People will use a different fork of BISPA

This PR removes the early return and simply prints the list of "invalid" files. Supports can decide if the files are obviously from piracy or not and I can continue to launch the game I have bought twice legitimately without being told I'm not allowed to put files in the game directory.

[Meivyn]

I'm just going to paste this here:

I don't want to facilitate piracy for a game that I love that much, Beat Saber is actually the game that convinced me to stop pirating games even if I'm broke and not employed.

There were already broken piracy checks in place that were way more problematic than my current implementation (it was checking if the game was in Downloads, and was allowing pirates due to a wrong return value).

It was always difficult for helpers to know when a user was using a pirate version; it's no longer the case, and the checks in place has been proven to be extremely effective at stopping pirates. Any active support can vouch for that. There are dozens of pirates that are manually flagged and won't get any help in the future.

There has been one issue reported at the time concerning desktop.ini that was fixed prior to release, then another one that was reported to me in DM about ReShade that is fixed on master (the one some modder was freaking out about). Another one was reported on the repo but hasn't been experienced by anyone else so far. Considering the slight amount of false positives happening because of the ini files check, I would like to find another solution, but as it stands, I can't find one that is as effective.

The latest game version broke my checks due to me not providing enough margin of error for the size check but BSIPA was already broken and the broken version is not publicly available. Cert-based verification would indeed be more reliable here.

Unlike what most seem to think (opinions don't matter here, facts are facts), there have been two cases of people using forks asking for help since I've changed the implementation of these checks, and both were spotted by me; support didn't notice. Support didn't see any case of false positives by themselves. This also suggests evidence that helpers aren't systematically checking and allowing pirates to go through, because the same techniques can be used to detect them regardless of these checks. So just logging a warning would have the same result. Not to mention that a vast majority of pirates wouldn't be coming for help to begin with, considering their mods are working. Pirates come for help because their mods aren't working.

More often than not, pirate games are outdated, including cracks. Sure forks may be rising in popularity in the future, but it doesn't matter.

This check also send the message that the modding community doesn't condone piracy of the game, and I'm not removing it.

I'm open to suggestions as long as they have essentially the same efficacy at stopping pirates than the current implementation, and that they don't make any network requests. I'm not going against DaNike's initial intents.