Adjustments to the config error window #1571
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
nikitabobko
commented
Jul 19, 2025
nikitabobko
commented
- Hide minimize button
- Enter to close the window even when TextEditor is focused
nikitabobko
force-pushed
the
bobko/config-window
branch
from
cfb0ccc to
f8b1ba3
Compare
|
cc @mobile-ar would be happy if you could leave your review |
nikitabobko
force-pushed
the
bobko/config-window
branch
from
f8b1ba3 to
455d46b
Compare
We no longer need `onExitCommand`, because enter now works even if the TextEditor is focused
nikitabobko
force-pushed
the
bobko/config-window
branch
from
455d46b to
a441f1c
Compare
nikitabobko
commented
Jul 19, 2025
| let cancelOnEnterBinding: Binding<String> = Binding( | ||
| get: { model.message?.body ?? "" }, | ||
| set: { newText in | ||
| if let prev = model.message?.body.count(where: \.isNewline), newText.count(where: \.isNewline) > prev { |
There was a problem hiding this comment.
Looks ugly, but it's the best I found
There was a problem hiding this comment.
Your option is better than my .onExitCommand. It's a little more complex in code but for sure provides better usability for the final user.
It might be the only option because all .keyPress option are only available in macOS 14.0 or newer.
nikitabobko
added a commit
that referenced
this pull request
Jul 19, 2025
We no longer need `onExitCommand`, because enter now works even if the TextEditor is focused closes #1571
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.