Grammar fixes #408
Merged
Grammar fixes #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed some grammar. It was missed at my last review.
|
Thanks! |
|
When are you planning to release a new version? It's highly anticipated. 🙂
…On Tue, May 7, 2019, 10:37 Niklas Fiekas ***@***.***> wrote:
Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#408 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADMYABPK2EPHASNNIUXDEVDPUE5VBANCNFSM4HLGPTFA>
.
|
|
Before the next release I need to find some time to finish #390. Currently the type signatures are half-broken. |
|
In chess/engine.py line 56 there is this line of code: This is spaghetti code. Maybe Mypy has trouble type-checking this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some grammar. It was missed at my last review.