Skip to content

regression: isNamedTuple(MyGenericTuple[int]) is false, should be true #13349

Closed
@timotheecour

Description

@timotheecour

/cc @cooldome #13347 introduced a regression:
isNamedTuple(MyGenericTuple[int]) is now false

Example

type Foo3[T] = tuple[x:int, y: T]
echo isNamedTuple(Foo3[int8])

Current Output

false

Expected Output

true

Additional Information

proc isNamedTuple(T: typedesc): bool =
  when T isnot tuple: result = false
  else:
    var t: T
    for name, _ in t.fieldPairs:
      when name == "Field0":
        return compiles(t.Field0)
      else:
        return true
    return false

however it had subtle issues so #13031 is good, but the code in semmagic.nim needs to fix this

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions