Skip to content

backport: nimExe (#13876) #14024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2020
Merged

backport: nimExe (#13876) #14024

merged 1 commit into from
Apr 20, 2020

Conversation

timotheecour
Copy link
Member

This was referenced Apr 19, 2020
Closed
Merged
Closed
@narimiran
Copy link
Member

So, this one should be backported to v1.2 branch? (And the other one to v1.0?)

@timotheecour
Copy link
Member Author

yes, that's what I specified in the base branch of this PR:

timotheecour wants to merge 1 commit into nim-lang:version-1-2 from timotheecour:v12_nimExe

since 1.2.0 was released, this can go to next release of that branch ( 1.2.2 )

@narimiran
Copy link
Member

that's what I specified in the base branch of this PR

Oh, I've missed that detail!

@narimiran narimiran merged commit 3411415 into nim-lang:version-1-2 Apr 20, 2020
@timotheecour timotheecour mentioned this pull request Apr 20, 2020
Merged
@timotheecour timotheecour deleted the v12_nimExe branch April 20, 2020 21:03
@timotheecour timotheecour mentioned this pull request Apr 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timotheecour @narimiran