Improve documentation for assertions #16988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Araq merged 4 commits into nim-lang:devel from konsumlamm:assertions

Feb 11, 2021

Contributor

konsumlamm commented Feb 9, 2021

Refs #3543.


          Improve documentation for assertions

ffe5abf

timotheecour reviewed

View reviewed changes

lib/system/assertions.nim Outdated Show resolved Hide resolved

timotheecour reviewed

View reviewed changes

lib/system/assertions.nim Show resolved Hide resolved

timotheecour reviewed

View reviewed changes

lib/system/assertions.nim Outdated Show resolved Hide resolved

timotheecour reviewed

View reviewed changes

lib/system/assertions.nim Outdated Show resolved Hide resolved

timotheecour reviewed

View reviewed changes

lib/system/assertions.nim Outdated Show resolved Hide resolved

Contributor Author

konsumlamm commented Feb 9, 2021

The CI failure seems to be caused by tests/assert/tassert_c.nim more or less hardcoding the expected stack trace...

Member

timotheecour commented Feb 9, 2021

The CI failure seems to be caused by tests/assert/tassert_c.nim more or less hardcoding the expected stack trace...

change tests/assert/tassert_c.nim code to:

const expected = """
tassert_c.nim(35)        tassert_c
tassert_c.nim(34)        foo
assertions.nim(*)       failedAssertImpl
assertions.nim(*)       raiseAssert
fatal.nim(*)            sysFatal"""

(it works, i checked)

if other files hardcode this, move tmatch to testament/lib/stdtest/testutils.nim so can be reused


          Apply suggestions

0ba8c19

Fix tests/assert/tassert_c.nim

timotheecour approved these changes

View reviewed changes


          Use runnableExamples

c850335

timotheecour mentioned this pull request

regression: runnableExamples in template should not affect caller #16993

Closed

Member

timotheecour commented Feb 10, 2021

@konsumlamm CI fails because of #16993, how about simply as workaround move the runnableExamples to module scope.


          Move runnableExamples to module scope

5dd720e

Araq merged commit d4f7f1d into nim-lang:devel

konsumlamm deleted the assertions branch

February 14, 2021 14:39

ardek66 pushed a commit to ardek66/Nim that referenced this pull request


          Improve documentation for assertions (nim-lang#16988)

052d678

* Improve documentation for assertions

* Apply suggestions

Fix tests/assert/tassert_c.nim

* Use runnableExamples

* Move runnableExamples to module scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet