Skip to content

close #13196 (json roundtrip) now that we have dragonbox #18316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2021
Merged

close #13196 (json roundtrip) now that we have dragonbox #18316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions tests/stdlib/tjson.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ import std/[json,parsejson,strutils]
from std/math import isNaN
when not defined(js):
import std/streams
import stdtest/testutils
from std/fenv import epsilon

proc testRoundtrip[T](t: T, expected: string) =
# checks that `T => json => T2 => json2` is such that json2 = json
Expand Down Expand Up @@ -325,6 +327,15 @@ block: # bug #18007
let a = parseJson($(%NaN)).to(float)
doAssert a.isNaN
whenRuntimeJs: discard # refs bug #18009
do:
testRoundtripVal(0.0): "0.0"
testRoundtripVal(-0.0): "-0.0"
block: # bug #15397, bug #13196
testRoundtripVal(1.0 + epsilon(float64)): "1.0000000000000002"
testRoundtripVal(0.12345678901234567890123456789): "0.12345678901234568"
block:
let a = "18446744073709551615"
let b = a.parseJson
Expand Down
11 changes: 11 additions & 0 deletions tests/stdlib/tjsonutils.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ discard """
import std/jsonutils
import std/json
from std/math import isNaN, signbit
from std/fenv import epsilon
from stdtest/testutils import whenRuntimeJs

proc testRoundtrip[T](t: T, expected: string) =
Expand Down Expand Up @@ -160,6 +161,16 @@ template fn() =
doAssert b[2].signbit
doAssert not b[3].signbit

block: # bug #15397, bug #13196
let a = 0.1
let x = 0.12345678901234567890123456789
let b = (a + 0.2, 0.3, x)
testRoundtripVal(b): "[0.30000000000000004,0.3,0.12345678901234568]"

testRoundtripVal(0.12345678901234567890123456789): "0.12345678901234568"
testRoundtripVal(epsilon(float64)): "2.220446049250313e-16"
testRoundtripVal(1.0 + epsilon(float64)): "1.0000000000000002"

block: # case object
type Foo = object
x0: float
Expand Down