Skip to content

Remove horizontal scrolling on mobile #24927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 5, 2025
Merged

Remove horizontal scrolling on mobile #24927

merged 3 commits into from
May 5, 2025

Conversation

AmjadHD
Copy link
Contributor

@AmjadHD AmjadHD commented May 2, 2025

No description provided.

@ire4ever1190
Copy link
Contributor

ire4ever1190 commented May 4, 2025

Are codeblocks still horizontally scrollable if they are too long?

@AmjadHD
Copy link
Contributor Author

AmjadHD commented May 4, 2025

Yes, but inline code is wrapped.

@AmjadHD
Copy link
Contributor Author

AmjadHD commented May 4, 2025

I don't understand the ci failure.

@Araq
Copy link
Member

Araq commented May 4, 2025

FAILURE: files differ: nimdoc/testproject/htmldocs/nimdoc.out.css

@AmjadHD
Copy link
Contributor Author

AmjadHD commented May 4, 2025

They don't differ.

@Araq Araq merged commit 8b82f5d into nim-lang:devel May 5, 2025
18 checks passed
Copy link
Contributor

github-actions bot commented May 5, 2025

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 8b82f5d

Hint: mm: orc; opt: speed; options: -d:release
179430 lines; 9.441s; 651.227MiB peakmem

@AmjadHD AmjadHD deleted the patch-1 branch May 5, 2025 21:46
narimiran pushed a commit that referenced this pull request May 6, 2025
@planetis-m
Copy link
Contributor

This commit broke the desktop version of docs as you can see from https://nim-lang.github.io/Nim/strutils.html

AmjadHD added a commit to AmjadHD/Nim that referenced this pull request May 30, 2025
Araq pushed a commit that referenced this pull request May 31, 2025
narimiran pushed a commit that referenced this pull request Jun 3, 2025
* Regression after #24927

(cherry picked from commit f80a076)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants