Add gcd & abs
#75
Merged
Add gcd & abs
#75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlesnoff
reviewed
Jan 12, 2022
| func gcd*(a, b: BigInt): BigInt = | ||
| ## Returns the greatest common divisor (GCD) of `a` and `b`. | ||
| runnableExamples: | ||
| assert gcd(54.initBigInt, 24.initBigInt) == 6.initBigInt |
There was a problem hiding this comment.
I do not know if it's preferable that runnableExamples are fast to execute, but one funny example (to showcase multiple precision integers too) would be :
let two = 2.initBigInt
assert gcd(two.pow(54) - 1, two.pow(24) - 1) == two.pow(6) - 1There was a problem hiding this comment.
In general it doesn't matter if runnableExamples are fast to execute, as they're only run when generating documentation. I'm not entirely convinced that this particular example is suited for the runnableExamples, but ofc we can add it to the test suite.
There was a problem hiding this comment.
Could you add the test and rebase @konsumlamm ?
Same as with the modular exponentiation, we will also get more conflicts if we let the PR pending.
May you then merge this PR @narimiran ?
dlesnoff
approved these changes
Jan 12, 2022
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsumes #66 (see #66 (comment)).
gcdis implemented using the binary GCD algorithm.