Skip to content

RF: Replace InvertT1w with upstream Rescale(invert=True) #1161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2018

Conversation

effigies
Copy link
Member

@effigies effigies commented Jun 6, 2018

Testing nipy/nipype#2599.

@effigies effigies changed the title [WIP] RF: Replace InvertT1w with upstream Rescale(invert=True) [Pending Nipype 1.1.0] RF: Replace InvertT1w with upstream Rescale(invert=True) Jun 6, 2018
@effigies effigies force-pushed the rf/upstream_rescale branch from 94b779d to 0843742 Compare July 5, 2018 18:49
@effigies effigies changed the title [Pending Nipype 1.1.0] RF: Replace InvertT1w with upstream Rescale(invert=True) RF: Replace InvertT1w with upstream Rescale(invert=True) Jul 5, 2018
@effigies
Copy link
Member Author

effigies commented Jul 5, 2018

This is ready for review.

Copy link
Member

@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review

Please check off boxes as applicable, and elaborate in comments below. Your review is not limited to these topics, as described in the reviewer guide

  • As the reviewer I confirm that there are no conflicts of interest for me to review this work.

Please check what applies in the following aspects of the PR:

Code documentation

  • New functions and modules are documented following the guidelines.
  • Existing code required amendments in documentation and has been updated.
  • Sufficient inline comments ensure readability by other contributors in the long term.

Documentation site

  • The modifications to fMRIPrep in this PR do not require extra documentation. This is a common situation when a bug fix that does not change the code base substantially is submitted.
  • This PR requires documentation. The corresponding documentation will be submitted as an additional PR in the future.
  • This PR requires extra documentation, and will be included within this PR. Please check the boxes that apply best:
    • An existing feature is substantially modified, changing the interface and/or logic of a module.
    • A new feature is being added, therefore full documentation of it will be included
    • This PR addresses an error in existing documentation.
  • Yes, all expected sections of documentation were generated by the CI build, and look as expected

Tests

  • The new functionalities in this PR are covered by the existing tests
  • New test batteries have been included with this PR

Data

  • This PR does not require any additional data to be uploaded to OSF.
  • This PR requires additional data for tests.

Dependencies: niworkflows

  • This PR does not require any update on niworkflows.
  • niworkflows has correctly been pinned.

Dependencies: Nipype

  • This PR does not require any update on nipype.
  • nipype has correctly been pinned.

Dependencies: other

  • This PR does not require any update on other dependencies.
  • Other dependencies have correctly been pinned.

Reports generated within CI tests

  • Yes, I have checked the reports of ds005 and they are not modified or the changes are as expected
  • Yes, I have checked the reports of ds054 and they are not modified or the changes are as expected
  • Yes, I have checked the reports of ds010 and they are not modified or the changes are as expected

Review Comments (other than those left inline with the code)

This looks great.

@oesteban oesteban merged commit 7bac765 into nipreps:master Jul 6, 2018
@effigies effigies deleted the rf/upstream_rescale branch July 9, 2018 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants