-
Notifications
You must be signed in to change notification settings - Fork 262
FIX: Correctly handle Philips DICOMs w/ derived volume #795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
4fb633f
DATA: Add nibabel-data/nitest-dicom submodule
effigies 2fa9872
enh+wip: support for philips dcm w/ derived volume
mgxd 7550262
fix: (py)dicom import
mgxd 3046347
fix: set missing import to None, ensure first frame exists before fet…
mgxd 5608f5c
fix: skip if frame does not have get attribute
mgxd d1dce02
sty: import specifics separately
mgxd ca5cd31
fix: allow non-diffusion 5D
mgxd b8f32bf
fix: remove unnecessary check
mgxd 21af99d
rf: better error handling, reflect change on frame_indices
mgxd 1040c51
add: warn if frames were altered
mgxd 8e2bd08
rf: condense frame checking try block
mgxd caa6df9
fix: ensure derived index is removed
mgxd 265511e
TEST: Update test DICOM file location
effigies File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule nitest-dicom
added at
ff6844
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.