FIX: Default value for sbatch_args (SLURMGraph) #1263
Conversation
Added a default value for self._sbatch_args in the SLURMGraph Plugin. This was not present and caused nipype to abort when sbatch_args was not specified when running the plugin.
| @@ -53,6 +53,8 @@ def __init__(self, **kwargs): | |||
| self._template = open(self._template).read() | |||
| if 'sbatch_args' in kwargs['plugin_args']: | |||
| self._sbatch_args = kwargs['plugin_args']['sbatch_args'] | |||
| else: # default argument for _sbatch_args | |||
| self._sbatch_args = '' | |||
There was a problem hiding this comment.
instead of using an else here perhaps set this at the beginning on __init__
|
You are right of course :-) Thanks! Will add this soon and update the pull request. |
|
@brennerd11 - any chance for an updated pull request here :) |
|
Hi! Sorry for the delay. Have not forgotten and will try to update the PR soon.
|
|
Updated the PR (finally)! Sorry for the delay! |
|
Hmmm... test ci/circleci test failed. From what I see seems like one of the FSL files is not downloadable at the moment (or was when the test ran). Is there a way to trigger rerunning the CI? |
|
If this is basically ready, could you merge master? |
|
Closed in favor of #2417. |
Added a default value for self._sbatch_args in the SLURMGraph Plugin.
This was not present and caused nipype to abort when sbatch_args was not specified when running the plugin.