-
Notifications
You must be signed in to change notification settings - Fork 533
[ENH/WIP] Add SPM Fieldmap Tool wrapper #1905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d1cee47
Add SPM Fieldmap Tool wrapper
jguillon 0fd77fc
Add first remarks from PR
jguillon 302be56
Merge branch 'master' into enh/spm-fieldmap-wrapper
jguillon 39715f2
Fix doctest filenames
jguillon c397662
Fix doctest and make vars more explicit
jguillon 88fee4a
Merge branch 'master' into enh/spm-fieldmap-wrapper
jguillon dd7569f
Merge remote-tracking branch 'nipy/master' into enh/spm-fieldmap-wrapper
jguillon a4994ef
Fix my doctest and add test_auto file
jguillon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for another round, but, this needs to be
'epi.nii'
, or some other file innipype/testing/data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries! It's on me! Btw, I went through the
CONTRIBUTING.md
file, but did not see any paragraph explaining how to run tests before submitting a PR. Maybe it would have save you some reviews of my code and others'.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that should probably be more clear. I just run
PYTHONPATH="." py.test --doctest-modules nipype
That tests all of nipype. You can specify a specific file you want to test, as well:
PYTHONPATH="." py.test --doctest-modules nipype/interfaces/spm/preprocess.py