Added support for a list of 3d files for TSNR calculation. #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if out_ext in ['mean', 'stddev']: | ||
| return os.path.abspath(base + "_tsnr_" + out_ext + ".nii.gz") | ||
| return os.path.abspath(base + "_tsnr_" + out_ext + ".nii") |
There was a problem hiding this comment.
can you use an input to determine compression? i'm really moving away from any uncompressed outputs. takes up too much space! so by default i would like to see things compressed. since this uses nibabel, perhaps allow any of the outputs that nibabel allows.
There was a problem hiding this comment.
Done. I understand your concerns, but to maximize out-of-the box compatibility I prefer to set default output type to uncompressed NIFTI. I did the same for AFNI in another PR.
satra
added a commit
that referenced
this pull request
Apr 16, 2012
Added support for a list of 3d files for TSNR calculation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.