JoinNode itersource synchronize #643
Conversation
… The default is True.
Conflicts: examples/smri_ants_registration.py
…t works in an ANTS release.
… The default is True.
…pype into join_itersource_synchronize Conflicts: nipype/pipeline/tests/test_join.py nipype/pipeline/utils.py
|
This looks very interesting! For now, a quick note to ask if you can edit the We are trying to flatten the package a bit from the user's perspective. |
|
@FredLoney - this is great - give me a few days to review this. but i think this will allow us to rewrite some workflows we were not able to do as a single step. i also want to make sure we have very clear examples of how to use this. |
|
I updated the github.com/FredLoney/nipype.git join_itersource_synchronize branch. I don't know if I need to resubmit the pull request. Fred From: Michael Waskom <[email protected]mailto:[email protected]> This looks very interesting! For now, a quick note to ask if you can edit the init.py files so that one can do: from nipype import JoinNode We are trying to flatten the package a bit from the user's perspective. — |
|
It automatically updates the pull request. But can you also add the import to A good check would be to have the doctest do |
|
Added import and changed the doctests. Fred From: Michael Waskom <[email protected]mailto:[email protected]> It automatically updates the pull request. But can you also add the import to nipype/init.py. A good check would be to have the doctest do from nipype import JoinNode — |
|
@FredLoney - i'm trying to rebase/merge this with the current master and it's going to take some effort as this contains other PRs merged into this as well, which have not been merged into master. if you have a good way of cherrypicking only the joinnode/itersource components into a separate branch that will be very useful. |
|
I rebased the branch from the Nipype master just before submission. The pull request should be from the github.com:FredLoney/nipype.git join_itersource_synchronize branch, not the master branch. Is there a way to verify that? Fred From: Satrajit Ghosh <[email protected]mailto:[email protected]> @FredLoneyhttps://github.com/FredLoney - i'm trying to rebase/merge this with the current master and it's going to take some effort as this contains other PRs merged into this as well, which have not been merged into master. if you have a good way of cherrypicking only the joinnode/itersource components into a separate branch that will be very useful. — |
|
I see where the extraneous commits were inadvertently merged into the tracking branch, which were rebased into the join_itersource_synchronize branch. If you'd like, I will cherry pick only the relevant commits. The extraneous commits are fairly harmless minor fixes. I planned to submit those as separate low-priority pull requests. Fred From: Me <[email protected]mailto:[email protected]> I rebased the branch from the Nipype master just before submission. The pull request should be from the github.com:FredLoney/nipype.git join_itersource_synchronize branch, not the master branch. Is there a way to verify that? Fred From: Satrajit Ghosh <[email protected]mailto:[email protected]> @FredLoneyhttps://github.com/FredLoney - i'm trying to rebase/merge this with the current master and it's going to take some effort as this contains other PRs merged into this as well, which have not been merged into master. if you have a good way of cherrypicking only the joinnode/itersource components into a separate branch that will be very useful. — |
Align spaces.
Simplify the graph expansion validation checks.
|
Merged by rebase in #658 |
This branch implements the JoinNode, itersource and synchronize enhancements described in https://groups.google.com/forum/?fromgroups=#!topic/nipy-user/CB3n0HwGT9c. A new chapter was added to the Users Guide. The join_test file exercises every JoinNode variation I could think of.