v2.13.2 makes nitropack incompatible with Node 20

[mydea]

Environment

The v2.13.2 release included, without being mentioned in the release notes , this commit: 182d6d3

However, rollup-plugin-visualizer v7 requires node 22, so this makes the whole of nitropack not compatible with node 20 anymore. Can we revert this update? It's especially bad because this is just a patch-level bump 😅

Reproduction

try to install nitropack latest v2 in a node app with node 20.

Describe the bug

should be able to install, as nitropack 2 supports node 20+. but it fails at install time. e.g.:

error rollup-plugin-visualizer@7.0.1: The engine "node" is incompatible with this module. Expected version ">=22". Got "20.19.2"

Additional context

No response

Logs

[pi0]

Do you also get a runtime error by using ignore-engines flag on install?

Node 20 is eol. there is no guarantee any other dep does not require it nor nitro pins exact versions.

[mydea]

well, nitropack v2 claims to support node 20, so I would expect it to not require any dependencies that do not support node 20. Sure, if a dependency releases a patch and suddenly changes their support policy that can be tricky (like what now happened with nitropack itself), but I think it is very reasonable to expect to not explicitly bump to versions that change your own support (the patch level bumped this dependency in a major step - 6x to 7x). I would also expect changes in node version support to be at least reflected in release notes etc. and not silently dropped.

nor nitro pins exact versions.

Well you bumped the dependency from 6.x to 7.x which immediately raised the required node version, so it is pinned to a version range that will never be compatible with what nitropack claims to support: "node": "^20.19.0 || >=22.12.0".

TLDR is it worth it all of this just to bump this honestly not too central-to-nitropack dependency to the latest version? 😬 I see this was overall removed in v3, so I don't really get why this has to be bumped in a major way inside of a patch-level release of nitropack v2.

If you'd be open to this, I'll happily open a PR reverting this specific bump so we can restore nitropack v2 to be compatible with node 20?

[pi0]

Just confirmed, nitropack@2.13.4 with fresh lockfile (pnpm) still works well on Node.js 20 for dev and build commands. It is not incompatible yet.

Any of other Nitro v2 (sub)dependencies might rightfully upgrade their engines field in a minor/patch at any point of time to require an actively supported version of Node.js.

Downgrading one dependency would be just a temporary and very fragile workaround and likely contributes to holding more unmaintained dependencies in the tree.

If you must keep testing unsupported Node.js versions like 20 in sentry CI, i suggest at least relaxing engines field check (of yarn) and rely on real runtime tests to confirm compatibility. I remember this happened before for other sub-dependencies in sentry CI.