Skip to content

ci: Track stable and beta in place of specific versions #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2016

Conversation

kamalmarhubi
Copy link
Member

No description provided.

@kamalmarhubi kamalmarhubi force-pushed the ci-stable-beta branch 2 times, most recently from fad3393 to b184c0a Compare January 15, 2016 17:57
@carllerche
Copy link
Contributor

Hey, I'm ok w/ adding stable & beta, but I would like to keep the 1.1.0, which represents the oldest supported Rust. Maybe add a comment above 1.1.0 saying "Oldest version of Rust supported by nix"

I'm also willing to bump that to 1.3.0 :)

@kamalmarhubi
Copy link
Member Author

I'm happy to support any version, just so long as we make it explicit. When you say "oldest supported Rust" do you mean by Rust core team? Or by nix?

@carllerche
Copy link
Contributor

By nix. Running CI against that version (1.3.0) will hopefully ensure that nix doesn't break compat with rust 1.3.0.

Basically, I only want to bump to newer Rust versions explicitly (vs by accident) and if there is a good reason to do so.

@kamalmarhubi kamalmarhubi force-pushed the ci-stable-beta branch 2 times, most recently from f402eeb to e432069 Compare January 19, 2016 01:15
@kamalmarhubi
Copy link
Member Author

I've changed this to test on all released versions 1.1.0+. The test should pass in about 45 minutes, at which point I'll merge it. :-)

@kamalmarhubi kamalmarhubi merged commit cca7ec2 into nix-rust:master Jan 19, 2016
@kamalmarhubi kamalmarhubi deleted the ci-stable-beta branch January 19, 2016 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants