More bitflags #243
Closed
More bitflags #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| use libc::{self, c_int}; | ||
|
|
||
| bitflags!{ | ||
| flags MmapFlags: c_int { |
There was a problem hiding this comment.
could we call these MapFlags for consistency?
|
Hi @fiveop! This is great, thanks for taking the time. I just have a couple of naming suggestions, because the naming of most flags seems to be |
|
I agree and will push a corresponding change. In addition, I will create a file which states this convention (in which we may than explicitly state further conventions) and open a PR for discussion. |
|
@fiveop +++ on the discussion + convention doc! This PR made me think o fit but haven't followed through. |
|
I'll wait for your extra commit then we can merge it. |
|
I had to rebase, so I'll open a new PR for tests. |
Merged
|
For future reference, rebase and force push will trigger tests just fine. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch converts some constants to
bitflagstypes. It should cover all flags insrc/sched.rsandsrc/sys/mman.rs. This is part of resolving #58.