Repository navigation
fix: add uclibc MIPS signal flags compatibility - #2671
Open
batkovic75 wants to merge 1 commit into
Open
batkovic75 wants to merge 1 commit into
batkovic75 wants to merge 1 commit into
Conversation
asomers
requested changes
Sep 15, 2025
asomers
left a comment
asomers
left a comment
Member
There was a problem hiding this comment.
Looks good, but could you please add a changelog entry?
batkovic75
force-pushed
the
fix-uclibc-signal-flags
branch
from
October 7, 2025 16:04
5fa15dc to
b5a1db1
Compare
Author
|
Sure, I added changelog/2671.fixed.md changelog entry following doc at CONTRIBUTING.md#pull-requests |
|
Is anything else needed here for this? I'm running into this as well. I see a lot of CI failures, I can help drive this home if needed. |
MIPS uclibc defines sa_flags as unsigned int instead of int, causing type mismatches. This adds conditional compilation to use the correct type (c_uint) for MIPS uclibc while maintaining compatibility with other platforms. Fixes signal handling on old uclibc systems (0.9.x series) commonly found on embedded MIPS devices.
batkovic75
force-pushed
the
fix-uclibc-signal-flags
branch
from
January 29, 2026 22:29
b5a1db1 to
9a6ff73
Compare
Author
|
@bahildebrand @asomers I rebased on master, CI are ok now |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I open this PR to fix signal handling compatibility for MIPS uclibc systems by addressing type mismatches in
sa_flags.MIPS uclibc (version 0.9.x series that can be found on some embedded devices) defines
sa_flagsasunsigned intinstead of the standardint, causing compilation failures when building nix on these systems.Changes
src/sys/signal.rsto uselibc::c_uintforSaFlags_ttype on MIPS with uclibclibc_bitflags!macro for MIPS uclibc compatibilityTesting
src/sys/statfs.rsuclibc handling)Note: No API changes, this is purely a compatibility fix for existing signal handling functionality. The public
API remains identical on all platforms.