Test: Fix solarish_tap test on big-endian targets#2743
Open
joshuaissac wants to merge 2 commits intonix-rust:masterfrom
Open
Test: Fix solarish_tap test on big-endian targets#2743joshuaissac wants to merge 2 commits intonix-rust:masterfrom
joshuaissac wants to merge 2 commits intonix-rust:masterfrom
Conversation
* patch to correct solarish_tap test for big-endian * changelog
Author
|
Check i686-unknown-linux-musl failing due to unrelated reason:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do
This change corrects the solarish_tap test on big-endian Solaris targets.
The two changes are to populate multi-byte numbers in the byte array using the native endianness (previous code assumed little-endianness), and to use a buffer that guarantees the required alignment when taking a pointer to it (previous code guaranteed only 1-byte alignment).
Tested on Solaris 11.4 (SPARC 64-bit).
Checklist:
CONTRIBUTING.md