Merged
Conversation
Member
|
Looks good. A couple of minor things:
|
fiveop
suggested changes
Oct 26, 2016
Contributor
fiveop
left a comment
fiveop
left a comment
There was a problem hiding this comment.
Just a small request regarding the markup in CHANGELOG.md
CHANGELOG.md
Outdated
| - Added function `epoll_create1` and bitflags `EpollCreateFlags` in | ||
| `::nix::sys::epoll` in order to support `::libc::epoll_create1`. | ||
| ([#410](https://github.com/nix-rust/nix/pull/410)) | ||
| - Added setresuid and setresgid for Linux |
Contributor
There was a problem hiding this comment.
Could you please markup the identifiers as code and reference the module they live in (::nix::unistd).
posborne
reviewed
Oct 26, 2016
src/unistd.rs
Outdated
| Errno::result(res).map(drop) | ||
| } | ||
|
|
||
| /// Sets the real, effective, and saved uid |
Member
There was a problem hiding this comment.
This is a real nit, but when rendered I think this will juxtapose the first line and "Further Reading", so it probably makes sense to add a period after the first line or do something like ([see setresuid(2)][...])
Member
|
Thanks for making the updates! |
These were both recently added to libc, add wrappers. Signed-off-by: Dylan Reid <dgreid@chromium.org> --- Changes since v2: Updated function comments and CHANGELOG Changes since v1: Add function comments, update CHANGELOG
Member
|
Looks good. @homu r+ |
Contributor
|
📌 Commit 6c85f43 has been approved by |
Contributor
|
⚡ Test exempted - status |
homu
added a commit
that referenced
this pull request
Oct 27, 2016
Add setresuid and setresgid These were both recently added to libc, add wrappers. Signed-off-by: Dylan Reid <dgreid@chromium.org>
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were both recently added to libc, add wrappers.
Signed-off-by: Dylan Reid dgreid@chromium.org