Skip to content

Asomers kevent #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2016
Merged

Asomers kevent #453

merged 2 commits into from
Oct 30, 2016

Conversation

posborne
Copy link
Member

This is a rebase of @asomers work on master to resolve a merge conflict so we can get things merged up.

@posborne
Copy link
Member Author

This replaces #442 so we can get things merged up.

@posborne
Copy link
Member Author

@homu r+

@homu
Copy link
Contributor

homu commented Oct 30, 2016

📌 Commit a0058f0 has been approved by posborne

@homu
Copy link
Contributor

homu commented Oct 30, 2016

⌛ Testing commit a0058f0 with merge 652e730...

homu added a commit that referenced this pull request Oct 30, 2016
Asomers kevent

This is a rebase of @asomers work on master to resolve a merge conflict so we can get things merged up.
@posborne posborne mentioned this pull request Oct 30, 2016
@asomers
Copy link
Member

asomers commented Oct 30, 2016

@posborne should we update CHANGELOG.md to reference PR #453 instead of PR #442 ?

@posborne
Copy link
Member Author

@posborne should we update CHANGELOG.md to reference PR #453 instead of PR #442 ?

Nah, #422 is fine since that's where the comments are and there will be a link to this. No worries.

@homu
Copy link
Contributor

homu commented Oct 30, 2016

☀️ Test successful - status

@homu homu merged commit a0058f0 into master Oct 30, 2016
@posborne posborne deleted the asomers-kevent branch October 30, 2016 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants