Skip to content

impl from<Duration> for TimeVal #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Roguelazer
Copy link

This should make working with various functions that take TimeVals more ergonomic

Resolves #494.

This should make working with various functions that take `TimeVal`s
more ergonomic
@posborne
Copy link
Member

@Roguelazer See the CI failures. i64 is not correct on all platforms for these casts.

@Roguelazer
Copy link
Author

I'm pretty sure I fixed it, although CI for OS X is hanging trying to set up the build VM.

@kamalmarhubi
Copy link
Member

Maybe add Into<Duration> as well?

@kamalmarhubi
Copy link
Member

As with #511, shall we hold off on this while #516 gets decided on?

@Susurrus Susurrus added this to the 1.0 milestone Nov 5, 2017
@Susurrus
Copy link
Contributor

Susurrus commented Dec 4, 2017

@kamalmarhubi I agree with your last comment, so let's go ahead and close this in favor of sorting all that out in one single issue.

@Susurrus Susurrus closed this Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants