Update minimum rust version to 1.9.0 #525
Conversation
Susurrus
force-pushed
the
min_rust
branch
2 times, most recently
from
e910f60 to
33878e2
Compare
|
Looks like Rust 1.9 fails on ARM targets, which isn't surprising given the comments in the code. Maybe it's time to switch to using |
Yeah, I built newer images somewhere along the line with 1.10 but never got around to fully updating nix to use the new stuff. I think the current is still using 1.7 images as it is pointed to There are images for several of the platforms pushed for 1.10 now, but I haven't updated nix but it would be great to move to something a bit newer. Long term, I think I prefer the approach that https://github.com/japaric/trust takes. |
|
So is there anything I should change in this PR, maybe move all the ARM stuff to use 1.10 and keep the other targets on 1.9? This still leaves the question about |
|
Note that |
|
I suggest, that you only change the README.md in this PR. We certainly do not support lower versions. Fixin the CI is different problem, thus I would leave the other two files alone. |
|
Done. |
|
@homu r+ After we are done setting up the new CI configuration, we should probably revisit this. |
|
📌 Commit 98dcc84 has been approved by |
|
⚡ Test exempted - status |
Update minimum rust version to 1.9.0 This is largely because of features used in `tempfile` from 1.8 and 1.9. This was tested locally, so we'll see what CI says. This does bring up the issue of the CI testing in the `ci` folder. That specifies the rust version as 1.7.0, but then when I looked at the docker images they seemed to only support 1.10, so maybe someone can comment on whether anything should be done about those things.
This is largely because of features used in
tempfilefrom 1.8 and 1.9. This was tested locally, so we'll see what CI says.This does bring up the issue of the CI testing in the
cifolder. That specifies the rust version as 1.7.0, but then when I looked at the docker images they seemed to only support 1.10, so maybe someone can comment on whether anything should be done about those things.