Add AioCb::from_boxed_slice #576
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added: - arm-unknown-linux-gnueabi - arm-unknown-linux-musleabi Removed: - powerpc64-unknown-linux-gnu (not suppported by nix) - mips64el-unknown-linux-gnu (not suppported by nix) - mipsel-unknown-linux-gnu (not suppported by nix)
Removed: - mips64-unknown-linux-gnu - mips64el-unknown-linux-gnu - arm-unknown-linux-musleabi
Fixes nix-rust#529, also refer to nix-rust#529 which first added this for the old CI infrastructure. Signed-off-by: Paul Osborne <[email protected]>
We need to raise it up to 1.13 because our test infrastructure requires it
The existing AioCb constructors work for simple programs where everything is stored on the stack. But in more complicated programs the borrow checker can't prove that a buffer will outlive the AioCb that references it. Fix this problem by introducting AioCb::from_boxed_slice, which takes a reference-counted buffer. Fixes nix-rust#575
|
☔ The latest upstream changes (presumably a076c7f) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Can you rebase onto master and update this PR? The |
|
Nope. Can't rebase to master because of issue #567 . But I can wait until new-ci/master is merged. |
|
Indeed, hoping to merge it today. |
|
Replaced by the rebased PR #582 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing AioCb constructors work for simple programs where
everything is stored on the stack. But in more complicated programs the
borrow checker can't prove that a buffer will outlive the AioCb that
references it. Fix this problem by introducting
AioCb::from_boxed_slice, which takes a reference-counted buffer.
Fixes #575