Skip to content
This repository was archived by the owner on Dec 29, 2022. It is now read-only.
This repository was archived by the owner on Dec 29, 2022. It is now read-only.

1.2.0 - passing wrong arguments #14

@albertosantini

Description

@albertosantini

In Node constructor there is an attempt to handle the old interface with id and callback with the new one, the config object.

The point is createNode passes only the first parameter, in this case id, vanishing the use of arguments in Node constructor.

I think the arguments trick should be done there and not in Node constructor: it is too late.

Indeed if I try to use the example contained in the README, it doesn't work.
Using the new interface and passing the config object with id and connect_callback it works nicely.

Luckly, my old code used require("flic").node and I didn't notice any problem.
After upgrading the code with createNode, the app stopped to work correctly.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions