Adding KUBECONFIG path validation instead of directly checking anon.conf #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small tweak to the KUBECONFIG setup.
Issue: Noticed that setup fails if anon.conf is not present in the same directory as the setup file. This is contradictory to exposing an environment variable KUBECONFIG that can be set to a path outside of the repo as well.
Fix: Instead of checking for existence of anon.conf in the same directory as the setup script, check if KUBECONFIG is set up correctly. Also modified README as KUBECONFIG now should be set before running the setup.