Skip to content

Run CRUD tests v6.0.0 and WAC tests v7.1.0 #1693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

michielbdejong
Copy link
Member

No description provided.

@michielbdejong michielbdejong requested a review from bourgeoa June 15, 2022 12:03
@michielbdejong michielbdejong changed the title Run CRUD tests v6.0.0 and WAC tests v7.0.0 Run CRUD tests v6.0.0 and WAC tests v7.1.0 Jun 30, 2022
@michielbdejong
Copy link
Member Author

I reenabled the skipped tests about solid/web-access-control-spec#105 and tagged v7.0.1 in the WAC tests. These tests were passing in the past, so I expect them to pass now as well, but let's wait for CI to complete.

Copy link
Member

@bourgeoa bourgeoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I have not checked the changes to web-access-control-tests from 6.0.0 to 7.1.0

Copy link
Member

@bourgeoa bourgeoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I have not checked the changes to web-access-control-tests from 6.0.0 to 7.1.0

@michielbdejong michielbdejong merged commit 73e73c8 into nodeSolidServer:main Jun 30, 2022
@michielbdejong michielbdejong deleted the latest-crud-and-wac-tests branch June 30, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants