This repository was archived by the owner on Feb 21, 2018. It is now read-only.
add minutes from 2015-11-19 meeting #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
|
||
| Alexis - FFI is invoking C functions from JS, most native modules could use | ||
| this to do their work. Some issues have come up regarding performance issues, | ||
| but there are some approaches which minimize performance, such as |
There was a problem hiding this comment.
minimize performance => minimize impact on performance
|
Minor nits. Other than that LGTM |
|
lgtm |
pmuellr
force-pushed
the
2015-11-19-wg
branch
from
dcb89d8 to
2b9dc16
Compare
|
Thanks everyone; merged in the suggested fixed and pushed on master. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.