Skip to content

add action that opens the PRs for us #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Dec 13, 2024

There are cases (e.g. when working on a release) where the current process is kinda slow, and we could speed it up by having the automation create the PR for us.

Having a workflow that can be triggered from the CLI would fix that.

# Create a PR for a post:
gh workflow run create-pr.yml --repo "https://github.com/nodejs/bluesky" \
  -F prTitle='vx.x.x release announcement' \
  -F richText='Node.js vx.x.x is out. Check the blog post at https://nodejs.org/…. TL;DR is

- New feature
- …'

# Create a PR for a retweet:
gh workflow run create-pr.yml --repo "https://github.com/nodejs/bluesky" \
  -F prTitle='Retweet vx.x.x release announcement' -F postURL=…

# Create a PR for a quote-RT:
gh workflow run create-pr.yml --repo "https://github.com/nodejs/bluesky" \
  -F prTitle='Retweet vx.x.x release announcement' -F postURL=… \
  -F richText=…

@aduh95 aduh95 changed the title add action to open PRs for is add action that opens the PRs for us Dec 19, 2024
@aduh95 aduh95 requested a review from joyeecheung December 19, 2024 19:27
Copy link
Contributor

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested over at https://github.com/bmuenzenmeyer/bluesky/pull/1/files - compared to the common use case - retweet json. output is identical to recent retweet at https://github.com/nodejs/bluesky/pull/34/files

overall, this is SUPER COOL.

I can see this being integrated into other actions and release automation.

With the advent of more automation, I'd love to add a bit more scrutiny to the repo., such as scorecard. This can be follow up of course.

@joyeecheung
Copy link
Member

So I am not sure if this was the checkbox I clicked...(I wasn't looking at the screen super carefully when I clicked save)

Screen Shot 2024-12-21 at 22 45 11

The audit log says this, which looks about right:

Screen Shot 2024-12-21 at 22 46 27

@joyeecheung joyeecheung merged commit 97295c7 into nodejs:main Dec 21, 2024
1 check passed
@aduh95 aduh95 deleted the open-pr-from-automation branch December 21, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants