ci: remove Node.js 8 from CI suite #783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #783 +/- ##
=======================================
Coverage 95.49% 95.49%
=======================================
Files 27 27
Lines 888 888
=======================================
Hits 848 848
Misses 40 40Continue to review full report at Codecov.
|
Contributor
Author
|
Seems the failure is completely unrelated to my change? |
richardlau
approved these changes
Jan 29, 2020
Member
Yes, CI is a bit flaky on Windows. |
targos
approved these changes
Jan 29, 2020
BethGriggs
approved these changes
Jan 29, 2020
Trott
approved these changes
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Node.js 8 is now EOL (as of December 31st, 2019), this PR proposes the removal of Node.js v8 from the GitHub Actions CI.
Checklist
npm testpasses