feat: Add auto-pr cron job #1314
Conversation
|
|
||
| on: | ||
| schedule: | ||
| - cron: 0 0 * * * |
There was a problem hiding this comment.
add a comment about what this means so I don't have to use https://crontab.guru/?
Co-authored-by: mary marchini <[email protected]>
|
|
||
| on: | ||
| schedule: | ||
| - cron: 0 0 * * * |
There was a problem hiding this comment.
| - cron: 0 0 * * * | |
| - cron: 0 * * * * |
Every hour instead of every day? Otherwise I assume people will be posting issues wondering when the next release will be available if it's potentially 23 hours delayed.
Could run it event more often of course, not like it takes a lot of resources/time
There was a problem hiding this comment.
@nschonni I still think this makes sense, fwiw
There was a problem hiding this comment.
I think every hour is better 👍
There was a problem hiding this comment.
or even more often - any issue running this every 10 minutes?
|
@nschonni land this? It's been 1.5 months without objections from @nodejs/docker folks or others |
| version: | ||
| - 10 | ||
| - 12 | ||
| - 14 |
There was a problem hiding this comment.
this will create 3 PRs if there are updates for all release lines, right? Should we instead just do ./update.sh without passing a version and use some node script to construct the PR title and body?
There was a problem hiding this comment.
./update.sh is broken atm and just runs against all versions even when you pass one as an argument.
Also, this will create PRs for yarn updates too even when there isn't a node update, since it doesn't have the -s flag.
I am interested in fixing update.sh or even perhaps porting it to a node script, if that is desired. It could be made more useful like returning what node versions it updated, etc.
There was a problem hiding this comment.
migrating to a js script makes sense to me.
As a temporary workaround, the script could run with -s first, and only if there is a diff, run again without the -s. But yeah, might make more sense to port it to a js script so it's a bit easier to work with more advanced logic?
There was a problem hiding this comment.
What should happen if there is a keys update (like there was a few days ago). Should any images be updated if there are no node updates?
There was a problem hiding this comment.
Good point, it should only create a PR if the Node version line changes. Key changes should only go in with a version bump
There was a problem hiding this comment.
Alright, I'll add some logic to grab the keys in the existing files to replay them on the templates, unless the node version changes.
There was a problem hiding this comment.
Can probably just try looking at the git diff result
There was a problem hiding this comment.
it should only create a PR if the Node version line changes
There might be bug fixes and such, so I think it's better to say that
- yarn version change
- key changes
only triggers an update if the node version changes - all other changes than those two should always trigger
No description provided.