Skip to content

Adjust GitHub Action Job names #1332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

PeterDaveHello
Copy link
Member

The job name was duplicated with the top level name.

Maybe just name it as "test build", just like the name of its test script, also, we may add some other tests in the future, use a different name will be less confusion.

cc #1194

The job name was duplicated with the top level name.
@PeterDaveHello PeterDaveHello requested review from nschonni and a team September 21, 2020 15:10
@SimenB
Copy link
Member

SimenB commented Sep 21, 2020

Name was added due to #1194 (comment) I believe. This PR didn't trigger any builds, so cannot verify

@PeterDaveHello
Copy link
Member Author

PeterDaveHello commented Sep 21, 2020

I triggered it here, but without a pull request, it be a different style, the point will be the second name:
https://github.com/PeterDaveHello/docker-node/actions/runs/265314963

The original one is something like #1331, which contains duplicated name in the two different level:
image

@SimenB
Copy link
Member

SimenB commented Sep 21, 2020

Yes, but on mobile there was no name. Can you make some fake change so we can verify the name is not lost on mobile layout?

@PeterDaveHello
Copy link
Member Author

@SimenB Try this one: PeterDaveHello#1

@SimenB
Copy link
Member

SimenB commented Sep 21, 2020

Doesn't show up on mobile for some reason
Screenshot_20200921-174420

@SimenB
Copy link
Member

SimenB commented Oct 13, 2020

Not an issue after #1339

image

@SimenB SimenB closed this Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants