Drop keyserver.pgp.com and reorder pgp key servers

[chorrell]

This drops the problematic keyserver.pgp.com gpg server (per docker-library/official-images#4006 (comment)) and reorders the server list to try the *.pool.sks-keyservers.net servers first, starting with p80.pool.sks-keyservers.net:80.

[chorrell]

Grrr. Yes... I missed the ones use by the yarn installation :)

I just pushed a commit to remove the remaining keyserver.pgp.com from the Docker files and update.sh script.

[chorrell]

And updated the chakracore template and Dockerfile too

[PeterDaveHello]

Maybe some of the commits should be squashed into one to have a better change history?
Looks like all the keyserver.pgp.com were removed now 👍

[SimenB]

I usually squash on merge, fwiw.

[PeterDaveHello]

I think maybe we could still preserve meaningful commits in this case, like the removal of keyserver.pgp.com, the re-order, which could be more meaningful.

[chorrell]

Yeah, I can do a rebase.

[chorrell]

I’m going to have to revisit this. The rebase didn’t work out the way I hoped it would. If someone else wants to redo this work in a new PR and drop this, go for it. I won’t be able to get to this today.

[PeterDaveHello]

Sorry that I closed it by accident, I don't mind to get it done few days later 🙂

[chorrell]

Meh, I just rebased it as one commit and updated the comments.

[PeterDaveHello]

@chorrell looks like p80.pool.sks-keyservers.net is also re-ordered?

[chorrell]

Yes, that was on purpose.

[PeterDaveHello]

Should we better also mention that in commit message? Otherwise, LGTM 👍

[chorrell]

I just updated the commit message :)

[PeterDaveHello]

Let's go for it.

[PeterDaveHello]

@chorrell hope you won't mind my adjustment on the PR title :) Try to mention the complete info to help feature tracing.