This repository was archived by the owner on Nov 6, 2022. It is now read-only.
allow content-length and transfer-encoding: c… #518
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@indutny what would be the best way to pass new option to the parser? Use settings? |
veshij
changed the title
|
Could anyone take a look at the change, please? |
ploxiln
reviewed
Jun 10, 2020
bnoordhuis
reviewed
Jul 7, 2020
There was a problem hiding this comment.
Mostly LGTM, thanks for doing this.
I just opened #519 to add more Content-Length testing because that was rather lacking from the test suite... It would be good to land that one first and rebase this PR on top of it.
(You can rebase it now, of course, no need to wait for the actual merge.) #519 has been merged.
ploxiln
reviewed
Jul 9, 2020
bnoordhuis
pushed a commit
to bnoordhuis/http-parser
that referenced
this pull request
Jul 10, 2020
Fixes: nodejs#517 PR-URL: nodejs#518 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Pierce Lopez <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #517