-
-
Notifications
You must be signed in to change notification settings - Fork 131
Conversation
beautiful |
thanks @rvagg! working on bringing it up to date with the latest 1.0.0 branch. |
This is perusable at https://iojs-homepage.herokuapp.com/ |
Great work! Would it be possible to include a link to the docs in the nav bar? Also, this might be silly of me to ask, but should we consider adding the twitter card info so we can display the logo in tweets that link the website? |
I'll be symlinking the latest release api docs at iojs.org/api/ so you can use that for now |
also the download link needs to go to iojs.org/dist/v1.0.0/ (i.e. without the "download" bit in it) |
(I know you're not responsible for all of these nits I'm picking up, but you're awake and working on this!) on the ES6 page, the command to find v8 version can be shortened to just |
I like it, this way we can also re-use the version card for past versions. My only question is: isn't the top bar a little empty then? |
Love it! Maybe cut the top bar for a few weeks until we have more pages/content? On Tuesday, January 13, 2015, Jeremiah Senkpiel [email protected]
|
this looks amazing, i agree with cutting the top bar until there is some full nav |
Glad you're liking it. :) The top bar "io.js" link is currently the only way to get to the homepage. I could add a home link to the footer, but mainly I added the top bar to get the page some visual weight. I can experiment with it. Would anyone be opposed to me converting this to a harp app with a build step, or should I keep trudging through the redundancy? |
@zeke can you try a rebase onto 1.0.0? If it fails all over don't worry about it I'll take care of it. |
@zeke I'd prefer something.. simpler? I don't really understand what harp all does. |
@Fishrock123 rebase attempts are pretty messy. Harp is pretty simple and has nice conventions. A harp app would look something like this:
|
@zeke Yeah, i might have to just leave all this be, I didn't realize your 1.0.0 patch was a merge commit. :S |
Sorry @Fishrock123, I suck at the gits. I can give it another try... |
@zeke doesn't matter too much now, I'm just using this branch. Between the up-merge, the rebase, and etc, things became... an "octopus merge" to quote @bnoordhuis haha It's fine. Updating 1.0.0 in a moment based on this and doing a couple minor things, linking docs, etc. |
Okay @Fishrock123 I "fixed" the conflicts and this is ready for merge again. Want to merge it into 1.0.0 so I don't keep diverging so badly? |
It's technically merged in, I'll close this when I close the other issue. (If you want to add to this, just delete your branch and pull down 1.0.0 again.. sorry for the trouble.) What can we do about a docs link? I was thinking of putting it in the header, but that would mean we have nav in two spots.. |
Sounds good. I'll scrap this branch and work off 1.0.0 again. Why not just add the docs link to the footer nav? |
This is based on existing work from #27.
index
faq
index on mobile
faq on mobile