Skip to content

ObjectWrap leak introduced in 8.2.0 #1602

@arsnyder16

Description

@arsnyder16

When using ObjectWrap that does not override a finalizer a memory leak is occurring.

I traced this back to #1514

Which introduced the following code which seems to trigger the leak. Removing this set eliminated the leak, but its not clear to me how this affects a basic or extended finalizer.

// Prevent ~ObjectWrap from calling napi_remove_wrap
instance->_ref = nullptr;

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions