Enable include files via package dependency #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boingoing
reviewed
Mar 17, 2017
| @@ -0,0 +1,7 @@ | |||
| const include = __dirname; | |||
| const isNodeApiBuiltin = process.versions.modules >= 52; | |||
There was a problem hiding this comment.
Is there a story for versioning N-API or do we always just provide whichever version is provided by the napi header/cc?
There was a problem hiding this comment.
For versions of node without N-API built-in, the N-API version will be the same as the node-api package version. For versions of node with N-API built-in, the N-API version will be the same as the node version. It's tricky because the former is determined at build time, while the latter is determined at run-time. This is an area we know we need to further define and document the behavior and best practices for native module developers.
digitalinfinity
approved these changes
Mar 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables other packages to get the N-API headers via a package dependency, the same way that NAN works. The header files would be referenced like this in
binding.gyp:'include_dirs': ["<!(node -p \"require('node-api').include\")"],The same mechanism can be used in the future to enable referencing other things from the package like a static lib or maybe a gyp dependency, when we add the source code for back-compat.
Currently I've set a package name of node-api, with the expectation that we'll be able to acquire that package name.