-
Notifications
You must be signed in to change notification settings - Fork 116
fix: lint during the landing process #435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #435 +/- ##
==========================================
- Coverage 82.58% 82.56% -0.02%
==========================================
Files 34 34
Lines 1665 1658 -7
==========================================
- Hits 1375 1369 -6
+ Misses 290 289 -1
Continue to review full report at Codecov.
|
Isn’t that going to fail on Windows? |
@richardlau you might be right - my esoteric windows knowledge is admittedly weaker 😅 |
Does git node land currently work on windows ? |
We could also only run |
We might want add some tests for these changes. |
I don't know we have tests for any of the actual patch downloading code right now - @joyeecheung what do you think? |
c2e78e2
to
bc7093e
Compare
@lundibundi i cleaned up the flow a bit - i think this is a bit better for users now |
Closes #427.
Runs
make lint
after the patch has been downloaded and applied, and optionally stage and amend updated files if lint fails.