fix install source path for openssl headers#14089
fix install source path for openssl headers#14089obastemur wants to merge 2 commits intonodejs:masterfrom obastemur:patch-1
Conversation
Seems node 0.12.x and node 0.10.x / jxcore use the same install script. This must be broken for a very long time. Moving the commit from jxcore/jxcore@fc1023f
|
ping! this issue is breaking the native addons using builtin openssl. |
|
LGTM /cc @joyent/node-coreteam |
|
LGTM |
|
@obastemur Thank you! LGTM, however it also applies to v0.10 and v0.12, so we may want to close this PR and submit another one against v0.10 that will get merged eventually into v0.12 and master. Also, I'm not familiar with writing binary add-ons that require OpenSSL, but was this issue not raised before because it "only" impacts developers who use Node.js' OpenSSL headers without using node-gyp? |
|
Yes. IMHO this part should be removed entirely. openssl and the headers from other dependencies should be copied into include/deps folder (similar to node-gyp include packages). I have this item on my todo list. Once I have something proper for node 0.10, 0.12 I will be bringing it here at least for a discussion. |
|
@obastemur Great thank you! |
PR: nodejs#14089 PR-URL: nodejs#14089 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Julien Gilli <jgilli@fastmail.fm>
PR: nodejs#14089 PR-URL: nodejs#14089 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Julien Gilli <jgilli@fastmail.fm>
|
Landed in 9d19dfb and 4028669. These will get merged in v0.12 eventually (sooner than later). Thank you again @obastemur! |
PR: nodejs#14089 PR-URL: nodejs#14089 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Julien Gilli <jgilli@fastmail.fm>
PR: nodejs#14089 PR-URL: nodejs#14089 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Julien Gilli <jgilli@fastmail.fm>
5 participants
Seems node 0.12.x and node 0.10.x / jxcore use the same install script. This must be broken for a very long time. Moving the commit from jxcore/jxcore@fc1023f