Skip to content

Build broken on FreeBSD #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
targos opened this issue Dec 4, 2019 · 5 comments
Closed

Build broken on FreeBSD #124

targos opened this issue Dec 4, 2019 · 5 comments

Comments

@targos
Copy link
Member

targos commented Dec 4, 2019

https://ci.nodejs.org/job/node-test-commit-freebsd/29907/nodes=freebsd11-x64/console

11:27:54 In file included from ../deps/v8/src/codegen/turbo-assembler.cc:5:
11:27:54 In file included from ../deps/v8/src/codegen/turbo-assembler.h:10:
11:27:54 ../deps/v8/src/base/template-utils.h:87:20: error: no member named 'logical_and' in namespace 'std'
11:27:54   return fold(std::logical_and<>{}, true, rest...);
11:27:54               ~~~~~^
11:27:54 ../deps/v8/src/base/template-utils.h:87:32: error: expected expression
11:27:54   return fold(std::logical_and<>{}, true, rest...);
11:27:54                                ^
11:27:54 ../deps/v8/src/base/template-utils.h:87:32: error: initializer list cannot be used on the right hand side of operator '>'
11:27:54   return fold(std::logical_and<>{}, true, rest...);
11:27:54                                ^~~
11:27:54 ../deps/v8/src/base/template-utils.h:86:16: error: no return statement in constexpr function
11:27:54 constexpr bool all(Args... rest) {
11:27:54                ^
11:27:54 4 errors generated.
11:27:54 gmake[2]: *** [tools/v8_gypfiles/v8_base_without_compiler.target.mk:637: /usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/out/Release/obj.target/v8_base_without_compiler/deps/v8/src/codegen/turbo-assembler.o] Error 1

Note that according to the CI run, compiler is too old:

WARNING: C++ compiler (CXX=ccache c++, 6.0.0) too old, need g++ 6.3.0 or clang++ 8.0.0
@targos
Copy link
Member Author

targos commented Dec 4, 2019

/cc @nodejs/platform-freebsd

@addaleax
Copy link
Member

addaleax commented Dec 4, 2019

Adding #include <functional> to src/base/template-utils.h is probably enough?

@targos targos mentioned this issue Dec 4, 2019
Closed
11 tasks
targos added a commit to targos/node that referenced this issue Dec 5, 2019
@targos
tentative fix for freebsd
3abeea9 
Refs: nodejs/node-v8#124
@targos
Copy link
Member Author

targos commented Dec 5, 2019

CI with that change: https://ci.nodejs.org/job/node-test-commit-freebsd/29927/

@targos
Copy link
Member Author

targos commented Dec 6, 2019

@addaleax that fixes it, thanks! Would you like to open a CL?

@addaleax
Copy link
Member

addaleax commented Dec 6, 2019

Sure, done: https://chromium-review.googlesource.com/c/v8/v8/+/1955584

@targos targos closed this as completed Dec 7, 2019
joyeecheung pushed a commit to joyeecheung/v8 that referenced this issue Jan 16, 2020
@addaleax
[base] add missing <functional> include
4066222 
The recently introduced usage of `std::logical_and` requires this.
This un-breaks building Node.js with the current V8 master branch
on FreeBSD.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/1940476
Refs: nodejs/node-v8#124
Change-Id: Ic9d63c40e1b533f7f1c59a05f8577ee0bb0d6aa1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1955584
Reviewed-by: Clemens Backes <[email protected]>
Commit-Queue: Clemens Backes <[email protected]>
Cr-Commit-Position: refs/heads/master@{#65367}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@addaleax @targos